Re: [PATCH net-next] net: phy: Expose phydev::dev_flags through sysfs

[Florian Fainelli]

On 3/10/21 2:48 PM, Jakub Kicinski wrote:
> On Wed, 10 Mar 2021 14:12:43 -0800 Florian Fainelli wrote:
>> phydev::dev_flags contains a bitmask of configuration bits requested by
>> the consumer of a PHY device (Ethernet MAC or switch) towards the PHY
>> driver. Since these flags are often used for requesting LED or other
>> type of configuration being able to quickly audit them without
>> instrumenting the kernel is useful.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
>> ---
>>  Documentation/ABI/testing/sysfs-class-net-phydev | 12 ++++++++++++
>>  drivers/net/phy/phy_device.c                     | 11 +++++++++++
>>  2 files changed, 23 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-class-net-phydev b/Documentation/ABI/testing/sysfs-class-net-phydev
>> index 40ced0ea4316..ac722dd5e694 100644
>> --- a/Documentation/ABI/testing/sysfs-class-net-phydev
>> +++ b/Documentation/ABI/testing/sysfs-class-net-phydev
>> @@ -51,3 +51,15 @@ Description:
>>  		Boolean value indicating whether the PHY device is used in
>>  		standalone mode, without a net_device associated, by PHYLINK.
>>  		Attribute created only when this is the case.
>> +
>> +What:		/sys/class/mdio_bus/<bus>/<device>/phy_dev_flags
>> +Date:		March 2021
>> +KernelVersion:	5.13
>> +Contact:	netdev@xxxxxxxxxxxxxxx
>> +Description:
>> +		32-bit hexadecimal number representing a bit mask of the
>> +		configuration bits passed from the consumer of the PHY
>> +		(Ethernet MAC, switch, etc.) to the PHY driver. The flags are
>> +		only used internally by the kernel and their placement are
>> +		not meant to be stable across kernel versions. This is intended
>> +		for facilitating the debugging of PHY drivers.
> 
> Why not debugfs, then?
> 

Mostly for consistency with what we already have exposed, I suppose that
could be moved to debugfs.

-- 
Florian