Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

From: Pierre-Louis Bossart
Date: Wed Mar 10 2021 - 11:42:03 EST




On 3/10/21 10:37 AM, Takashi Iwai wrote:
On Wed, 10 Mar 2021 17:18:14 +0100,
Mark Brown wrote:

On Wed, Mar 10, 2021 at 09:44:07AM -0600, Pierre-Louis Bossart wrote:
On 3/10/21 7:35 AM, Mark Brown wrote:

Just change it to a system level check for ACPI, checking for OF would
leave problems for board files or any other alternative firmware
interfaces.

did you mean if (!IS_ENABLED(CONFIG_ACPI)) ?

Is there a runtime check?

Well, basically both DMI and ACPI are completely different things, so
I don't think it's right to check the availability of ACPI as a signal
of the availability of DMI.

would this work?

if (!IS_ENABLED(CONFIG_DMI))
return 0;