Re: [PATCH] perf/x86/kvm: Fix inverted pebs_no_isolation check

From: Jim Mattson
Date: Wed Mar 10 2021 - 10:37:05 EST


On Wed, Mar 10, 2021 at 7:24 AM Andi Kleen <ak@xxxxxxxxxxxxxxx> wrote:
>
> The pebs_no_isolation optimization check is inverted. We want to disable
> PEBS isolation when the microcode is at least the revision in the table,
> not for older microcode. So remove the extra !.
The original code was correct because of the double negative. A "good"
CPU _has_ PEBS isolation. It's bad to have pebs_no_isolation.