Re: [PATCH] bus: mhi: Make firmware image optional for controller

From: Manivannan Sadhasivam
Date: Wed Mar 10 2021 - 09:16:06 EST


On Tue, Mar 09, 2021 at 10:46:35AM -0800, Bhaumik Bhatt wrote:
> Some controllers can opt to not have MHI download a firmware
> image to have the device bootup and can find the device in a
> pass through execution environment, ready to go. Thus, MHI
> controllers for those devices do not need fw_image defined.
> Make it optional to accommodate different bootup modes.
>
> Suggested-by: Loic Poulain <loic.poulain@xxxxxxxxxx>
> Signed-off-by: Bhaumik Bhatt <bbhatt@xxxxxxxxxxxxxx>

Applied to mhi-next!

Thanks,
Mani

> ---
> include/linux/mhi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 56c4c52..838a3c4 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -296,7 +296,7 @@ struct mhi_controller_config {
> * @wake_db: MHI WAKE doorbell register address
> * @iova_start: IOMMU starting address for data (required)
> * @iova_stop: IOMMU stop address for data (required)
> - * @fw_image: Firmware image name for normal booting (required)
> + * @fw_image: Firmware image name for normal booting (optional)
> * @edl_image: Firmware image name for emergency download mode (optional)
> * @rddm_size: RAM dump size that host should allocate for debugging purpose
> * @sbl_size: SBL image size downloaded through BHIe (optional)
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>