Re: [PATCH v4 01/22] x86/fpu/xstate: Modify the initialization helper to handle both static and dynamic buffers

[Borislav Petkov]

On Sun, Feb 21, 2021 at 10:56:16AM -0800, Chang S. Bae wrote:
> diff --git a/arch/x86/kernel/fpu/core.c b/arch/x86/kernel/fpu/core.c
> index 571220ac8bea..d43661d309ab 100644
> --- a/arch/x86/kernel/fpu/core.c
> +++ b/arch/x86/kernel/fpu/core.c
> @@ -192,8 +192,18 @@ static inline void fpstate_init_fstate(struct fregs_state *fp)
>  	fp->fos = 0xffff0000u;
>  }
>  
> -void fpstate_init(union fpregs_state *state)
> +/*
> + * @fpu: If NULL, use init_fpstate
> + */

A note either for you - if you get to resend a new revision - or for the
committer to fix up this into a proper kernel-doc style:

Documentation/doc-guide/kernel-doc.rst

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg