Re: [PATCH V1] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

[sbhanu]

On 2021-03-10 02:20, Konrad Dybcio wrote:
> Hi!
>
>
> > +
> > +&sdhc_1 {
> > +	status = "okay";
> > +
> > +	pinctrl-names = "default", "sleep";
> > +	pinctrl-0 = <&sdc1_on>;
> > +	pinctrl-1 = <&sdc1_off>;
> > +
> > +	vmmc-supply = <&vreg_l7b_2p9>;
> > +	vqmmc-supply = <&vreg_l19b_1p8>;
> > +
>
> Redundant newline, please remove
>
>
> > +
> > +			mmc-ddr-1_8v;
> > +			mmc-hs200-1_8v;
> > +			mmc-hs400-1_8v;
> > +			mmc-hs400-enhanced-strobe;
> > +
> > +			status = "disabled";
> > +
>
> Redundant newline, please remove
sure
> > +		};
> > +
> > +		sdhc_2: sdhci@8804000 {
> > +			compatible = "qcom,sdhci-msm-v5";
> > +			reg = <0 0x08804000 0 0x1000>;
> > +
> > +			iommus = <&apps_smmu 0x100 0x0>;
> > +			interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>,
> > +					<GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
> > +			interrupt-names = "hc_irq", "pwr_irq";
> > +
> > +			clocks = <&gcc GCC_SDCC2_APPS_CLK>,
> > +					<&gcc GCC_SDCC2_AHB_CLK>,
> > +					<&rpmhcc RPMH_CXO_CLK>;
> > +			clock-names = "core", "iface", "xo";
> > +
> > +			bus-width = <4>;
> > +
> > +			no-mmc;
> > +			no-sdio;
> > +
> > +			max-frequency = <202000000>;
> > +
> > +			qcom,dll-config = <0x0007642c>;
> > +
> > +			status = "disabled";
> > +
>
> Redundant newline, please remove
sure
> Konrad