Re: [PATCH v1 02/14] vfio: Update vfio_add_group_dev() API

From: Jason Gunthorpe
Date: Wed Mar 10 2021 - 07:20:22 EST


On Wed, Mar 10, 2021 at 07:48:38AM +0000, Christoph Hellwig wrote:
> On Mon, Mar 08, 2021 at 02:47:40PM -0700, Alex Williamson wrote:
> > Rather than an errno, return a pointer to the opaque vfio_device
> > to allow the bus driver to call into vfio-core without additional
> > lookups and references. Note that bus drivers are still required
> > to use vfio_del_group_dev() to teardown the vfio_device.
> >
> > Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
>
> This looks like it is superseded by the
>
> vfio: Split creation of a vfio_device into init and register ops

Yes, that series puts vfio_device everywhere so APIs like Alex needs
to build here become trivial.

The fact we both converged on this same requirement is good

Jason