[PATCH] greybus/operation: Drop reference when message has been set

From: Lv Yunlong
Date: Wed Mar 10 2021 - 04:11:25 EST


In gb_operation_response_send, get an extra reference
before gb_message_send() with this comment "/* Reference will
be dropped when message has been sent. */". Therefore, we
should drop the got reference not only in the error branch,
but also in the complete branch.

Signed-off-by: Lv Yunlong <lyl2019@xxxxxxxxxxxxxxxx>
---
drivers/greybus/operation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c
index 296f0b93d171..500b3fe53a04 100644
--- a/drivers/greybus/operation.c
+++ b/drivers/greybus/operation.c
@@ -855,7 +855,7 @@ static int gb_operation_response_send(struct gb_operation *operation,
if (ret)
goto err_put_active;

- /*Drop reference after message send successfully. */
+ /*Drop reference after message send completes. */
gb_operation_put_active(operation);
gb_operation_put(operation);

--
2.25.1