Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

[Sergei Shtylyov]

Hello!

On 10.03.2021 5:26, zhangqing wrote:

[...]
> > +    if (of_device_is_compatible(node, "loongson,liointc-2.0")) {
> > +        base = liointc_get_reg_byname(node, "main");
> > +        if (!base) {
> > +            err = -ENODEV;
> > +            goto out_free_priv;
> > +        }
> > +        for (i = 0; i < LIOINTC_NUM_CORES; i++) {
> > +            priv->core_isr[i] =
> > +                liointc_get_reg_byname(node, core_reg_names[i]);
> > Please write assignments on a single line.
>
> In addition, write assignments on a single line
>
>                   for (i = 0; i <LIOINTC_NUM_CORES; i++)
>                           priv->core_isr[i] = liointc_get_reg_byname(node, 
> core_reg_names[i]);
>
>      It is 92 characters, more than 80 characters...

   The new line length limit is 100 chars. :-)

[...]

MBR, Sergei