Re: [PATCH] usb: renesas_usbhs: fix error return code of usbhsf_pkt_handler()

[Jia-Ju Bai]

On 2021/3/10 10:54, Yoshihiro Shimoda wrote:
> Hi Jia-Ju,
>
> > From: Jia-Ju Bai, Sent: Tuesday, March 9, 2021 10:39 PM
> > On 2021/3/9 19:59, Yoshihiro Shimoda wrote:
> > > Hi Jia-Ju,
> > >
> > > Thank you for the patch!
> > >
> > > > From: Jia-Ju Bai, Sent: Sunday, March 7, 2021 6:01 PM
> > > >
> > > > When __usbhsf_pkt_get() returns NULL to pkt, no error return code of
> > > > usbhsf_pkt_handler() is assigned.
> > > Yes. Also I realized that no error return code of usbhsf_pkt_handler()
> > > was assigned if the type value was unexpected value. So, I'm thinking
> > > initial value of ret should be -EINVAL instead of 0.
> > This is okay to me.
> > Need I write a new patch for this?
> Thank you for your reply. I can write such a new patch with your
> Reported-by for this as minor refactoring of the usbhsf_pkt_handler().
> May I write such a patch?

Okay, sure :)


Best wishes,
Jia-Ju Bai