Re: [PATCH] media: videobuf2: Fix integer overrun in allocation

[Sergey Senozhatsky]

On (21/03/10 00:43), Ricardo Ribalda wrote:
> The plane_length is an unsigned integer. So, if we have a size of
> 0xffffffff bytes we incorrectly allocate 0 bytes instead of 1 << 32.

Hi Ricardo,

> @@ -223,8 +223,10 @@ static int __vb2_buf_mem_alloc(struct vb2_buffer *vb)
>  	 * NOTE: mmapped areas should be page aligned
>  	 */
>  	for (plane = 0; plane < vb->num_planes; ++plane) {
> +		unsigned long size = vb->planes[plane].length;
> +
>  		/* Memops alloc requires size to be page aligned. */
> -		unsigned long size = PAGE_ALIGN(vb->planes[plane].length);
> +		size = PAGE_ALIGN(size);
>  
>  		/* Did it wrap around? */
>  		if (size < vb->planes[plane].length)

Shouldn't the same be done in vb2_mmap()?

	-ss