RE: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang

[Brelinski, TonyX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Paul Menzel
> Sent: Friday, March 5, 2021 1:04 AM
> To: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>; Brandeburg, Jesse
> <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>;
> Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx; linux-
> hardening@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through
> warnings for Clang
> 
> Dear Gustavo,
> 
> 
> Thank you for working on that.
> 
> Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> > warning by explicitly adding a break statement instead of just letting
> > the code fall through to the next case.
> 
> It would be nice to have a short summary of the discrepancy between GCC
> and clang, and it was decided to go with the “clang decision”, and not have
> clang adapt to GCC.
> 
> > Link: https://github.com/KSPP/linux/issues/115
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> > ---
> >   drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
> >   1 file changed, 1 insertion(+)

Tested-by: Tony Brelinski <tonyx.brelinski@xxxxxxxxx> A Contingent Worker at Intel