Re: [PATCH] kvm: lapic: add module parameters for LAPIC_TIMER_ADVANCE_ADJUST_MAX/MIN

[Sean Christopherson]

On Wed, Mar 03, 2021, Haiwei Li wrote:
> On 21/3/3 10:09, lihaiwei.kernel@xxxxxxxxx wrote:
> > From: Haiwei Li <lihaiwei@xxxxxxxxxxx>
> > 
> > In my test environment, advance_expire_delta is frequently greater than
> > the fixed LAPIC_TIMER_ADVANCE_ADJUST_MAX. And this will hinder the
> > adjustment.
> 
> Supplementary details:
> 
> I have tried to backport timer related features to our production
> kernel.
> 
> After completed, i found that advance_expire_delta is frequently greater
> than the fixed value. It's necessary to trun the fixed to dynamically
> values.

Does this reproduce on an upstream kernel?  If so...

  1. How much over the 10k cycle limit is the delta?
  2. Any idea what causes the large delta?  E.g. is there something that can
     and/or should be fixed elsewhere?
  3. Is it platform/CPU specific?

Ideally, KVM would play nice with "all" environments by default without forcing
the admin to hand-tune things.