Re: [PATCH v2] include: Remove pagemap.h from blkdev.h

From: Dan Williams
Date: Tue Mar 09 2021 - 15:47:51 EST


On Tue, Mar 9, 2021 at 11:59 AM Matthew Wilcox (Oracle)
<willy@xxxxxxxxxxxxx> wrote:
>
> My UEK-derived config has 1030 files depending on pagemap.h before
> this change. Afterwards, just 326 files need to be rebuilt when I
> touch pagemap.h. I think blkdev.h is probably included too widely,
> but untangling that dependency is harder and this solves my problem.
> x86 allmodconfig builds, but there may be implicit include problems
> on other architectures.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> ---
> v2: Fix CONFIG_SWAP=n implicit use of pagemap.h by swap.h. Increases
> the number of files from 240, but that's still a big win -- 68%
> reduction instead of 77%.
>
[..]
> drivers/nvdimm/btt.c | 1 +
> drivers/nvdimm/pmem.c | 1 +

For the nvdimm bits:

Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>