Re: [PATCH 2/2] pinctrl: qcom: sc7280: Fix SDC1_RCLK configurations

From: Bjorn Andersson
Date: Tue Mar 09 2021 - 15:12:26 EST


On Mon 01 Mar 23:21 CST 2021, Rajendra Nayak wrote:

> Fix SDC1_RCLK configurations which are in a different register so fix the
> offset from 0xb3000 to 0xb3004.
>
> Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
>

Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Regards,
Bjorn

> Reported-by: Veerabhadrarao Badiganti <vbadigan@xxxxxxxxxxxxxx>
> Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
> ---
> drivers/pinctrl/qcom/pinctrl-sc7280.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> index 49c4347..9d41abf 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> @@ -1440,7 +1440,7 @@ static const struct msm_pingroup sc7280_groups[] = {
> [173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _),
> [174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _),
> [175] = UFS_RESET(ufs_reset, 0xbe000),
> - [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0),
> + [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3004, 0, 6),
> [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6),
> [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3),
> [179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0),
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>