Re: [PATCH v5 1/6] irqdomain: Introduce irq_domain_create_simple() API

From: Andy Shevchenko
Date: Tue Mar 09 2021 - 11:42:09 EST


On Tue, Mar 9, 2021 at 6:36 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Mon, Mar 8, 2021 at 8:45 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> > Linus Walleij pointed out that ird_domain_add_simple() gained
> > additional functionality and can't be anymore replaced with
> > a simple conditional. In preparation to upgrade GPIO library
> > to use fwnode, introduce irq_domain_create_simple() API which is
> > functional equivalent to the existing irq_domain_add_simple(),
> > but takes a pointer to the struct fwnode_handle as a parameter.
> >
> > While at it, amend documentation to mention irq_domain_create_*()
> > functions where it makes sense.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Acked-by: Marc Zyngier <maz@xxxxxxxxxx>
>
> Excellent work Andy!

Thanks!

> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> I suggest Bartosz just apply this with the rest to the GPIO tree.

Yes, that's the idea.

--
With Best Regards,
Andy Shevchenko