Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

From: Andy Shevchenko
Date: Tue Mar 09 2021 - 06:06:21 EST


On Fri, Mar 5, 2021 at 9:05 PM Jonathan Cameron
<Jonathan.Cameron@xxxxxxxxxx> wrote:
>
> On Fri, 5 Mar 2021 14:38:13 +0100
> Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
>
> > Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized for
> > the touchscreen use case. By implementing it as IIO ADC device, we can
> > make use of resistive-adc-touch and iio-hwmon drivers.
> >
> > So far, this driver was tested with custom version of resistive-adc-touch driver,
> > since it need to be extended to make use of Z1 and Z2 channels. The X/Y
> > are working without additional changes.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
>
> Hi Oleksij,
>
> To consider this as a possible long term route instead of just making this
> a touchscreen driver, we'll want to see those mods to the resistive-adc-touch.
> Of course that doesn't stop review of this in the meantime.
>
> There are quite a few things in here that feel pretty specific to the touchscreen
> usecase. That makes me wonder if this is a sensible approach or not.

I'm wondering if this has any similarities with existing drivers under
drivers/input/touchscreen.

--
With Best Regards,
Andy Shevchenko