Re: [PATCH RFCv2] mm/madvise: introduce MADV_POPULATE_(READ|WRITE) to prefault/prealloc memory

[David Hildenbrand]

On 09.03.21 08:35, Rolf Eike Beer wrote:
> > diff --git a/mm/internal.h b/mm/internal.h
> > index 9902648f2206..a5c4ed23b1db 100644
> > --- a/mm/internal.h
> > +++ b/mm/internal.h
> > @@ -340,6 +340,9 @@ void __vma_unlink_list(struct mm_struct *mm,
> > struct vm_area_struct *vma);
> >   #ifdef CONFIG_MMU
> >   extern long populate_vma_page_range(struct vm_area_struct *vma,
> >   		unsigned long start, unsigned long end, int *nonblocking);
> > +extern long faultin_vma_page_range(struct vm_area_struct *vma,
> > +				   unsigned long start, unsigned long end,
> > +				   bool write, int *nonblocking);
> >   extern void munlock_vma_pages_range(struct vm_area_struct *vma,
> >   			unsigned long start, unsigned long end);
> >   static inline void munlock_vma_pages_all(struct vm_area_struct *vma)
>
> The parameter name does not match the one in the implementation.
>
> Otherwise the implementation looks fine AFAICT.

Hehe, you can tell how I copy-pasted from populate_vma_page_range(), 
because there, the variable names are messed up, too :)

Will fix (most probably populate_vma_page_range() as well in a cleanup 
patch), thanks!

--
Thanks,

David / dhildenb