Re: [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang

From: Gustavo A. R. Silva
Date: Mon Mar 08 2021 - 16:16:37 EST


On Sat, Mar 06, 2021 at 11:39:35AM +0100, Marius Zachmann wrote:
> On 06.03.21 at 10:53:59 CET, Gustavo A. R. Silva wrote
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of letting the code fall
> > through to the next case.
> >
> > Link: https://github.com/KSPP/linux/issues/115
> > Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>
> Acked-by: Marius Zachmann <mail@xxxxxxxxxxxxxxxxx>

Thanks, Marius.

--
Gustavo

>
> > ---
> > drivers/hwmon/corsair-cpro.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c
> > index 591929ec217a..fa6aa4fc8b52 100644
> > --- a/drivers/hwmon/corsair-cpro.c
> > +++ b/drivers/hwmon/corsair-cpro.c
> > @@ -310,6 +310,7 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type,
> > default:
> > break;
> > }
> > + break;
> > default:
> > break;
> > }
> >
>
>
>
>