Re: [PATCH v6 19/34] xlink-core: Add xlink core device tree bindings

[mark gross]

On Fri, Mar 05, 2021 at 03:03:00PM -0600, Rob Herring wrote:
> On Fri, Feb 12, 2021 at 02:22:49PM -0800, mgross@xxxxxxxxxxxxxxx wrote:
> > From: Seamus Kelly <seamus.kelly@xxxxxxxxx>
> > 
> > Add device tree bindings for keembay-xlink.
> > 
> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Reviewed-by: Mark Gross <mgross@xxxxxxxxxxxxxxx>
> > Signed-off-by: Mark Gross <mgross@xxxxxxxxxxxxxxx>
> > Signed-off-by: Seamus Kelly <seamus.kelly@xxxxxxxxx>
> > ---
> >  .../bindings/misc/intel,keembay-xlink.yaml    | 29 +++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> > new file mode 100644
> > index 000000000000..5ac2e7fa5b5e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> > @@ -0,0 +1,29 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright (c) Intel Corporation. All rights reserved.
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/misc/intel,keembay-xlink.yaml#";
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> > +
> > +title: Intel Keem Bay xlink
> > +
> > +maintainers:
> > +  - Seamus Kelly <seamus.kelly@xxxxxxxxx>
> > +
> > +description: |
> > +  The Keem Bay xlink driver enables the communication/control sub-system
> > +  for internal and external communications to the Intel Keem Bay SoC.
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - const: intel,keembay-xlink
> > +
> > +additionalProperties: False
> > +
> > +examples:
> > +  - |
> > +    xlink {
> > +        compatible = "intel,keembay-xlink";
> 
> A node with only a compatible is almost always abusing DT just to 
> instantiate your driver.

Is it normal to make drivers that want to abuse DT in this way platform
devices?

Any advice would be welcome and helful.

thanks!

--mark