Re: [PATCH v2 4/5] mtd: spi-nor: Move Software Write Protection logic out of the core

From: Vignesh Raghavendra
Date: Mon Mar 08 2021 - 12:29:48 EST




On 3/6/21 3:20 PM, Tudor Ambarus wrote:
> It makes the core file a bit smaller and provides better separation
> between the Software Write Protection features and the core logic.
> All the next generic software write protection features (e.g. Individual
> Block Protection) will reside in swp.c.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
> ---
> drivers/mtd/spi-nor/Makefile | 2 +-
> drivers/mtd/spi-nor/core.c | 407 +---------------------------------
> drivers/mtd/spi-nor/core.h | 4 +
> drivers/mtd/spi-nor/swp.c | 419 +++++++++++++++++++++++++++++++++++

Hmmm, name swp.c does not seem intuitive to me. How about expanding it a
bit:

soft-wr-protect.c or software-write-protect.c ?

Regards
Vignesh