Re: [PATCH v2] tracing/tools: Remove unneeded semicolon

From: Viktor.Rosendahl
Date: Mon Mar 08 2021 - 06:48:28 EST


On Mon, 2021-03-08 at 02:24 +0000, Xu Wang wrote:
> fix semicolon.cocci warning:
> tools/tracing/latency/latency-collector.c:1021:2-3: Unneeded semicolon
>
> Signed-off-by: Xu Wang <vulab@xxxxxxxxxxx>

Reviewed-by: Viktor Rosendahl <Viktor.Rosendahl@xxxxxx>

> ---
> Changes since v2:
> - Fix another instance of superfluous semicolon.
> ---
> tools/tracing/latency/latency-collector.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/tracing/latency/latency-collector.c
> b/tools/tracing/latency/latency-collector.c
> index b69de9263ee6..3a2e6bb781a8 100644
> --- a/tools/tracing/latency/latency-collector.c
> +++ b/tools/tracing/latency/latency-collector.c
> @@ -1018,7 +1018,7 @@ static long go_to_sleep(const struct entry *req)
> cond_timedwait(&printstate.cond, &printstate.mutex, &future);
> if (time_has_passed(&future))
> break;
> - };
> + }
>
> if (printstate_has_new_req_arrived(req))
> delay = -1;
> @@ -1941,7 +1941,7 @@ static void scan_arguments(int argc, char *argv[])
> if (value < 0) {
> warnx("TIME must be >= 0\n");
> show_usage();
> - ;
> + exit(0);
> }
> trace_enable = true;
> use_random_sleep = true;

best regards,

Viktor