Re: [PATCH v2] erofs: fix bio->bi_max_vecs behavior change

From: Gao Xiang
Date: Sun Mar 07 2021 - 21:38:30 EST


Hi Chao,

On Mon, Mar 08, 2021 at 09:29:30AM +0800, Chao Yu wrote:
> On 2021/3/6 12:04, Gao Xiang wrote:
> > From: Gao Xiang <hsiangkao@xxxxxxxxxx>
> >
> > Martin reported an issue that directory read could be hung on the
> > latest -rc kernel with some certain image. The root cause is that
> > commit baa2c7c97153 ("block: set .bi_max_vecs as actual allocated
> > vector number") changes .bi_max_vecs behavior. bio->bi_max_vecs
> > is set as actual allocated vector number rather than the requested
> > number now.
> >
> > Let's avoid using .bi_max_vecs completely instead.
> >
> > Reported-by: Martin DEVERA <devik@xxxxxxxxxx>
> > Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxx>
>
> Looks good to me, btw, it needs to Cc stable mailing list?
>
> Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>
>

Thanks for your review. <= 5.11 kernels are not impacted.
For now, this only impacts 5.12-rc due to a bio behavior
change (see commit baa2c7c97153). So personally I think
just leave as it is is fine.

Thanks,
Gao Xiang

> Thanks,
>