[PATCH v3 1/3] input: gpio-keys: Remove extra call to input_sync

From: Paul Cercueil
Date: Sun Mar 07 2021 - 17:28:08 EST


The input_sync() function is already called after the loop in
gpio_keys_report_state(), so it does not need to be called after each
iteration within gpio_keys_gpio_report_event().

Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
---

Notes:
v2: Keep the input_sync() within gpio_keys_report_state() so that it's
not called at every iteration of the loop.

v3: No change

drivers/input/keyboard/gpio_keys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index 77bac4ddf324..7fcb2c35c5cc 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -373,7 +373,6 @@ static void gpio_keys_gpio_report_event(struct gpio_button_data *bdata)
} else {
input_event(input, type, *bdata->code, state);
}
- input_sync(input);
}

static void gpio_keys_gpio_work_func(struct work_struct *work)
@@ -382,6 +381,7 @@ static void gpio_keys_gpio_work_func(struct work_struct *work)
container_of(work, struct gpio_button_data, work.work);

gpio_keys_gpio_report_event(bdata);
+ input_sync(bdata->input);

if (bdata->button->wakeup)
pm_relax(bdata->input->dev.parent);
--
2.30.1