Re: [PATCH] clk: Fix doc of clk_get_parent

From: Paul Cercueil
Date: Sun Mar 07 2021 - 10:59:14 EST




Le dim. 7 mars 2021 à 14:30, Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx> a écrit :
On Sun, Mar 07, 2021 at 02:29:07PM +0000, Paul Cercueil wrote:
Hi,

Le dim. 7 mars 2021 à 14:27, Russell King - ARM Linux admin
<linux@xxxxxxxxxxxxxxx> a écrit :
> On Sun, Mar 07, 2021 at 02:06:26PM +0000, Paul Cercueil wrote:
> > On error, or when the passed parameter is NULL, the return value is
> > NULL
> > and not a PTR_ERR()-encoded value.
>
> No, the documentation is accurate. The CCF is just an implementation
> of the API, the file you are modifying is the definitive API
> documentation.

Well, then the code has to be fixed, because right now it returns NULL on
error, since the 2.6 days.

And you consider NULL to be an error? A NULL clock isn't defined to be
an error by the API.

Fair enough. Ignore my patch then.

Cheers,
-Paul