Re: [PATCH v3 0/6] iio: Add output buffer support

From: Jonathan Cameron
Date: Sat Mar 06 2021 - 12:35:40 EST


On Fri, 5 Mar 2021 08:57:08 +0000
"Hennerich, Michael" <Michael.Hennerich@xxxxxxxxxx> wrote:

> Hi Jonathan and others,
>
> With output/dac buffer support the semantics of the scan_element type may change.
>
> Today the Format is [be|le]:[s|u]bits/storagebitsXrepeat[>>shift].
>
> While shift (if specified) is the shift that needs to be applied prior to masking out unused bits.
>
> So far so good and it sounds universal.
>
> However, we use the right shift (operator) for that, which makes sense for capture devices.
> For output devices the more logical operator would be the left shift.
>
> I'm not proposing a new Format here. I just want to get some agreement that for an output device
>
> le:s12/16>>4
>
> is understood as a left shift of 4, since the unused bits are then on the LSB.

Good question. Guess I wasn't thinking ahead when I came up with that :)

I'm not sure I'd mind if we did decide to define a new format for output
buffers. Feels like it should be easy to do.

What do others think?

Jonathan


>
> Thoughts?
>
> Best Regards,
> Michael
>
> Analog Devices GmbH
> Michael Hennerich                      
> Otl-Aicher Strasse 60-64
> D-80807 Muenchen; Germany
>
> Sitz der Gesellschaft München, Registergericht München HRB 40368,
> Geschäftsführer: Stefan Steyerl, Michael Paul Sondel, Yoon Ah Oh
>
>