Re: [PATCH v5 02/15] gpio: regmap: set gpio_chip of_node

[Andy Shevchenko]

On Sat, Mar 6, 2021 at 5:57 PM Álvaro Fernández Rojas <noltari@xxxxxxxxx> wrote:
>
> This is needed for properly registering GPIO regmap as a child of a regmap
> pin controller.

Thanks for an update!

...

>         chip->parent = config->parent;

> +       if (config->fwnode)

This...

> +               chip->of_node = to_of_node(config->fwnode);

> +       else
> +               chip->of_node = dev_of_node(config->parent);

...and these lines are not needed. If there is no of_node in the chip,
the GPIO library will take care of it to be parent's one.

-- 
With Best Regards,
Andy Shevchenko