Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling

From: Paul E. McKenney
Date: Fri Mar 05 2021 - 13:27:27 EST


On Fri, Mar 05, 2021 at 04:41:49PM +0100, Björn Töpel wrote:
> On 2021-03-05 16:36, Alan Stern wrote:
> > On Fri, Mar 05, 2021 at 11:28:23AM +0100, Björn Töpel wrote:
> > > From: Björn Töpel <bjorn.topel@xxxxxxxxx>
> > >
> > > A misspelled invokation of git-grep, revealed that
> > -------------------^
> >
> > Smetimes my brain is a little slow... Do you confirm that this is a
> > joke?
> >
>
> I wish, Alan. I wish.
>
> Looks like I can only spel function names correctly.

Heh! I missed that one completely. Please see below for a wortschmied
commit.

Thanx, Paul

------------------------------------------------------------------------

commit 1c737ce34715db9431f6b034f92dbf09d954126d
Author: Björn Töpel <bjorn.topel@xxxxxxxxx>
Date: Fri Mar 5 11:28:23 2021 +0100

tools/memory-model: Fix smp_mb__after_spinlock() spelling

A misspelled git-grep regex revealed that smp_mb__after_spinlock()
was misspelled in explanation.txt.

This commit adds the missing "_" to smp_mb__after_spinlock().

Fixes: 1c27b644c0fd ("Automate memory-barriers.txt; provide Linux-kernel memory model")
[ paulmck: Apply Alan Stern commit-log feedback. ]
Signed-off-by: Björn Töpel <bjorn.topel@xxxxxxxxx>
Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx>

diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt
index f9d610d..5d72f31 100644
--- a/tools/memory-model/Documentation/explanation.txt
+++ b/tools/memory-model/Documentation/explanation.txt
@@ -2510,7 +2510,7 @@ they behave as follows:
smp_mb__after_atomic() orders po-earlier atomic updates and
the events preceding them against all po-later events;

- smp_mb_after_spinlock() orders po-earlier lock acquisition
+ smp_mb__after_spinlock() orders po-earlier lock acquisition
events and the events preceding them against all po-later
events.