Re: [RFT PATCH v3 22/27] tty: serial: samsung_tty: Use devm_ioremap_resource

From: Andy Shevchenko
Date: Fri Mar 05 2021 - 10:20:35 EST


On Fri, Mar 5, 2021 at 12:55 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxxxxx> wrote:
>
> On 04/03/2021 22:38, Hector Martin wrote:
> > This picks up the non-posted I/O mode needed for Apple platforms to
> > work properly.
> >
> > This removes the request/release functions, which are no longer
> > necessary, since devm_ioremap_resource takes care of that already. Most
> > other drivers already do it this way, anyway.
> >

For the patches 18-22, with Krzysztof's and mine comments addressed
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> > Signed-off-by: Hector Martin <marcan@xxxxxxxxx>
> > ---
> > drivers/tty/serial/samsung_tty.c | 25 +++----------------------
> > 1 file changed, 3 insertions(+), 22 deletions(-)
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>
> Best regards,
> Krzysztof



--
With Best Regards,
Andy Shevchenko