Re: [RFT PATCH v3 21/27] tty: serial: samsung_tty: IRQ rework

From: Krzysztof Kozlowski
Date: Fri Mar 05 2021 - 05:53:02 EST


On 04/03/2021 22:38, Hector Martin wrote:
> * Split out s3c24xx_serial_tx_chars from s3c24xx_serial_tx_irq,
> where only the latter acquires the port lock. This will be necessary
> on platforms which have edge-triggered IRQs, as we need to call
> s3c24xx_serial_tx_chars to kick off transmission from outside IRQ
> context, with the port lock held.
>
> * Rename s3c24xx_serial_rx_chars to s3c24xx_serial_rx_irq for
> consistency with the above. All it does now is call two other
> functions anyway.
>
> Signed-off-by: Hector Martin <marcan@xxxxxxxxx>
> ---
> drivers/tty/serial/samsung_tty.c | 34 +++++++++++++++++++-------------
> 1 file changed, 20 insertions(+), 14 deletions(-)
>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>

Best regards,
Krzysztof