Re: [PATCH] qxl: Fix uninitialised struct field head.surface_id

From: Gerd Hoffmann
Date: Fri Mar 05 2021 - 04:40:43 EST


On Thu, Mar 04, 2021 at 09:49:28AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The surface_id struct field in head is not being initialized and
> static analysis warns that this is being passed through to
> dev->monitors_config->heads[i] on an assignment. Clear up this
> warning by initializing it to zero.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: a6d3c4d79822 ("qxl: hook monitors_config updates into crtc, not encoder.")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Pushed to drm-misc-fixes.

thanks,
Gerd