Re: [PATCH 107/141] net: core: Fix fall-through warnings for Clang

From: Gustavo A. R. Silva
Date: Thu Mar 04 2021 - 17:56:56 EST


Hi all,

It's been more than 3 months; who can take this, please? :)

Thanks
--
Gustavo

On Fri, Nov 20, 2020 at 12:38:03PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> ---
> net/core/dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 82dc6b48e45f..9efb03ce504d 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -5214,6 +5214,7 @@ static int __netif_receive_skb_core(struct sk_buff **pskb, bool pfmemalloc,
> goto another_round;
> case RX_HANDLER_EXACT:
> deliver_exact = true;
> + break;
> case RX_HANDLER_PASS:
> break;
> default:
> --
> 2.27.0
>