Re: [PATCH 076/141] decnet: Fix fall-through warnings for Clang

From: Gustavo A. R. Silva
Date: Thu Mar 04 2021 - 17:54:14 EST


Hi all,

It's been more than 3 months; who can take this, please? :)

Thanks
--
Gustavo

On Fri, Nov 20, 2020 at 12:35:01PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> ---
> net/decnet/dn_route.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
> index 4cac31d22a50..2f3e5c49a221 100644
> --- a/net/decnet/dn_route.c
> +++ b/net/decnet/dn_route.c
> @@ -1407,7 +1407,7 @@ static int dn_route_input_slow(struct sk_buff *skb)
> flags |= RTCF_DOREDIRECT;
>
> local_src = DN_FIB_RES_PREFSRC(res);
> -
> + break;
> case RTN_BLACKHOLE:
> case RTN_UNREACHABLE:
> break;
> --
> 2.27.0
>