Re: [PATCH v2] gpio: regmap: set gpio_chip of_node

From: Andy Shevchenko
Date: Thu Mar 04 2021 - 10:24:04 EST


On Thu, Mar 4, 2021 at 5:18 PM Álvaro Fernández Rojas <noltari@xxxxxxxxx> wrote:
>
> This is needed for properly registering gpio regmap as a child of a regmap
> pin controller.

> + chip->of_node = config->of_node ?: dev_of_node(config->parent);

After a closer look I have no clue why you need this patch at all.
The second part, i.e. assigning parent's fwnode, is done already in
the GPIO library core.
The first part, keeping fwnode in the regmap configuration puzzles me. Why?

--
With Best Regards,
Andy Shevchenko