Re: [PATCH v4 02/15] gpio: regmap: set gpio_chip of_node

From: Álvaro Fernández Rojas
Date: Thu Mar 04 2021 - 10:08:04 EST


Hi Andy,

> El 4 mar 2021, a las 11:35, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> escribió:
>
> On Thu, Mar 4, 2021 at 10:57 AM Álvaro Fernández Rojas
> <noltari@xxxxxxxxx> wrote:
>>
>> This is needed for properly registering gpio regmap as a child of a regmap
>
> gpio -> GPIO
>
>> pin controller.
>
> ...
>
>> + * @of_node: (Optional) The device node
>
>> + struct device_node *of_node;
>
> Can we use fwnode from day 1, please?

Could you explain this? I haven’t dealt with fwnode never :$
BTW, this is done to fix this check when parsing gpio ranges:
https://github.com/torvalds/linux/blob/f69d02e37a85645aa90d18cacfff36dba370f797/drivers/gpio/gpiolib-of.c#L933-L934

>
> --
> With Best Regards,
> Andy Shevchenko

Best regards,
Álvaro.