Re: [PATCH v9 6/9] crypto: Add NIST P384 curve parameters

[Stefan Berger]

On 3/4/21 12:28 AM, Herbert Xu wrote:
> On Thu, Feb 25, 2021 at 11:07:59AM -0500, Stefan Berger wrote:
> > From: Saulo Alessandre <saulo.alessandre@xxxxxxxxxx>
> >
> > * crypto/ecc_curve_defs.h
> >    - add nist_p384 params
> >
> > * include/crypto/ecdh.h
> >    - add ECC_CURVE_NIST_P384
> >
> > Signed-off-by: Saulo Alessandre <saulo.alessandre@xxxxxxxxxx>
> > Tested-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> > ---
> >   crypto/ecc_curve_defs.h | 32 ++++++++++++++++++++++++++++++++
> >   include/crypto/ecdh.h   |  1 +
> >   2 files changed, 33 insertions(+)
> Can you reorder the patches so that the crypto patches come first
> and then I can apply them?

Yes, sounds good.

Are you going to take the other patches as well, except for maybe 9/9, 
which depends on Nayan's patch series. Mimi suggested to me to ask you 
whether you could create a topic branch where we can apply other patches 
to, such as Nayna's?

The NIST P384 patch temporarily introduces this warning, which goes away 
when the immediately following patch (current 7/9) is applied. Is this 
an issue or should I squash Saulo's patches or put the top hunk from 7/9 
into 6/9?


In file included from crypto/ecc.c:38:
crypto/ecc_curve_defs.h:76:25: warning: ?nist_p384? defined but not used 
[-Wunused-variable]
   76 | static struct ecc_curve nist_p384 = {
      |                         ^~~~~~~~~

   Stefan


> Thanks,