Re: [PATCH] platform/x86: intel-hid: Support Lenovo ThinkPad X1 Tablet Gen 2

From: Hans de Goede
Date: Thu Mar 04 2021 - 08:45:38 EST


Hi,

On 2/22/21 3:15 PM, Alban Bedel wrote:
> Like a few other system the Lenovo ThinkPad X1 Tablet Gen 2 miss the
> HEBC method, which prevent the power button from working. Add a quirk
> to enable the button array on this system family and fix the power
> button.
>
> Signed-off-by: Alban Bedel <albeu@xxxxxxx>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
> drivers/platform/x86/intel-hid.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
> index 2f5b8d09143e..57cc92891a57 100644
> --- a/drivers/platform/x86/intel-hid.c
> +++ b/drivers/platform/x86/intel-hid.c
> @@ -90,6 +90,13 @@ static const struct dmi_system_id button_array_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x2 Detachable"),
> },
> },
> + {
> + .ident = "Lenovo ThinkPad X1 Tablet Gen 2",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X1 Tablet Gen 2"),
> + },
> + },
> { }
> };
>
>