Re: [PATCH] platform/x86: Switch to using the new API kobj_to_dev()

[Hans de Goede]

Hi,

On 2/22/21 8:00 AM, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/platform/x86/ideapad-laptop.c:523:60-61: WARNING opportunity
> for kobj_to_dev()
> 
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>

Patch does not apply, please resend it rebased on the latest pdx86/for-next branch:

https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next

Regards,

Hans

> ---
>  drivers/platform/x86/ideapad-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 5b81baf..d6ca4f0 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -520,7 +520,7 @@ static umode_t ideapad_is_visible(struct kobject *kobj,
>  				 struct attribute *attr,
>  				 int idx)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct ideapad_private *priv = dev_get_drvdata(dev);
>  	bool supported;
>  
>