Re: [V2][PATCH] vt: keyboard, fix uninitialized variables warning

[Andy Shevchenko]

On Thu, Mar 04, 2021 at 11:10:48AM +0800, Li Wang wrote:
> drivers/tty/vt/keyboard.c: In function 'vt_do_kdgkb_ioctl':
> drivers/tty/vt/keyboard.c: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   return ret;
>          ^~~
> drivers/tty/vt/keyboard.c: warning: 'kbs' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   kfree(kbs);


Let me add one more comment and summarize altogether:
 - Jiri wants you to have different error code
 - Greg (and I noticed that as well) wants you to add a proper commit message,
   and not just some output of some tool w/o context
 - I want you to send a new version w/o chaining to the previous thread, so
   start new (email) thread every time you send a new version

Waiting for v3 in a separate email thread, thanks!

-- 
With Best Regards,
Andy Shevchenko