Re: [PATCH 1/3] Revert "netfilter: x_tables: Update remaining dereference to RCU"

From: Florian Westphal
Date: Thu Mar 04 2021 - 02:45:01 EST


Mark Tomlinson <mark.tomlinson@xxxxxxxxxxxxxxxxxxx> wrote:
> This reverts commit 443d6e86f821a165fae3fc3fc13086d27ac140b1.
>
> This (and the following) patch basically re-implemented the RCU
> mechanisms of patch 784544739a25. That patch was replaced because of the
> performance problems that it created when replacing tables. Now, we have
> the same issue: the call to synchronize_rcu() makes replacing tables
> slower by as much as an order of magnitude.
>
> See https://lore.kernel.org/patchwork/patch/151796/ for why using RCU is
> not a good idea.

Please don't add links for the rationale.