Re: [PATCH v3 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg
From: kernel test robot
Date: Thu Mar 04 2021 - 01:11:10 EST
Hi Shengjiu,
I love your patch! Yet something to improve:
[auto build test ERROR on asoc/for-next]
[also build test ERROR on shawnguo/for-next v5.12-rc1 next-20210303]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Shengjiu-Wang/Add-audio-driver-base-on-rpmsg-on-i-MX-platform/20210225-110931
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: m68k-randconfig-r035-20210304 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/298ca32a06d8ed79ef0183fc1bcc0f56d02d9ec0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Shengjiu-Wang/Add-audio-driver-base-on-rpmsg-on-i-MX-platform/20210225-110931
git checkout 298ca32a06d8ed79ef0183fc1bcc0f56d02d9ec0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
In file included from arch/m68k/include/asm/div64.h:6,
from include/linux/math.h:5,
from include/linux/kernel.h:13,
from include/linux/clk.h:13,
from sound/soc/fsl/fsl_rpmsg.c:4:
sound/soc/fsl/fsl_rpmsg.c: In function 'fsl_rpmsg_hw_params':
include/asm-generic/div64.h:226:28: warning: comparison of distinct pointer types lacks a cast
226 | (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
| ^~
sound/soc/fsl/fsl_rpmsg.c:60:11: note: in expansion of macro 'do_div'
60 | npll = (do_div(rate, 8000) ? rpmsg->pll11k : rpmsg->pll8k);
| ^~~~~~
In file included from include/linux/err.h:5,
from include/linux/clk.h:12,
from sound/soc/fsl/fsl_rpmsg.c:4:
include/asm-generic/div64.h:239:25: warning: right shift count >= width of type [-Wshift-count-overflow]
239 | } else if (likely(((n) >> 32) == 0)) { \
| ^~
include/linux/compiler.h:77:40: note: in definition of macro 'likely'
77 | # define likely(x) __builtin_expect(!!(x), 1)
| ^
sound/soc/fsl/fsl_rpmsg.c:60:11: note: in expansion of macro 'do_div'
60 | npll = (do_div(rate, 8000) ? rpmsg->pll11k : rpmsg->pll8k);
| ^~~~~~
In file included from arch/m68k/include/asm/div64.h:6,
from include/linux/math.h:5,
from include/linux/kernel.h:13,
from include/linux/clk.h:13,
from sound/soc/fsl/fsl_rpmsg.c:4:
>> include/asm-generic/div64.h:243:22: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types]
243 | __rem = __div64_32(&(n), __base); \
| ^~~~
| |
| unsigned int *
sound/soc/fsl/fsl_rpmsg.c:60:11: note: in expansion of macro 'do_div'
60 | npll = (do_div(rate, 8000) ? rpmsg->pll11k : rpmsg->pll8k);
| ^~~~~~
include/asm-generic/div64.h:217:38: note: expected 'uint64_t *' {aka 'long long unsigned int *'} but argument is of type 'unsigned int *'
217 | extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor);
| ~~~~~~~~~~^~~~~~~~
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +/__div64_32 +243 include/asm-generic/div64.h
^1da177e4c3f41 Linus Torvalds 2005-04-16 219
^1da177e4c3f41 Linus Torvalds 2005-04-16 220 /* The unnecessary pointer compare is there
^1da177e4c3f41 Linus Torvalds 2005-04-16 221 * to check for type safety (n must be 64bit)
^1da177e4c3f41 Linus Torvalds 2005-04-16 222 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 223 # define do_div(n,base) ({ \
^1da177e4c3f41 Linus Torvalds 2005-04-16 224 uint32_t __base = (base); \
^1da177e4c3f41 Linus Torvalds 2005-04-16 225 uint32_t __rem; \
^1da177e4c3f41 Linus Torvalds 2005-04-16 226 (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
911918aa7ef6f8 Nicolas Pitre 2015-11-02 227 if (__builtin_constant_p(__base) && \
911918aa7ef6f8 Nicolas Pitre 2015-11-02 228 is_power_of_2(__base)) { \
911918aa7ef6f8 Nicolas Pitre 2015-11-02 229 __rem = (n) & (__base - 1); \
911918aa7ef6f8 Nicolas Pitre 2015-11-02 230 (n) >>= ilog2(__base); \
461a5e51060c93 Nicolas Pitre 2015-10-30 231 } else if (__div64_const32_is_OK && \
461a5e51060c93 Nicolas Pitre 2015-10-30 232 __builtin_constant_p(__base) && \
461a5e51060c93 Nicolas Pitre 2015-10-30 233 __base != 0) { \
461a5e51060c93 Nicolas Pitre 2015-10-30 234 uint32_t __res_lo, __n_lo = (n); \
461a5e51060c93 Nicolas Pitre 2015-10-30 235 (n) = __div64_const32(n, __base); \
461a5e51060c93 Nicolas Pitre 2015-10-30 236 /* the remainder can be computed with 32-bit regs */ \
461a5e51060c93 Nicolas Pitre 2015-10-30 237 __res_lo = (n); \
461a5e51060c93 Nicolas Pitre 2015-10-30 238 __rem = __n_lo - __res_lo * __base; \
911918aa7ef6f8 Nicolas Pitre 2015-11-02 239 } else if (likely(((n) >> 32) == 0)) { \
^1da177e4c3f41 Linus Torvalds 2005-04-16 240 __rem = (uint32_t)(n) % __base; \
^1da177e4c3f41 Linus Torvalds 2005-04-16 241 (n) = (uint32_t)(n) / __base; \
^1da177e4c3f41 Linus Torvalds 2005-04-16 242 } else \
^1da177e4c3f41 Linus Torvalds 2005-04-16 @243 __rem = __div64_32(&(n), __base); \
^1da177e4c3f41 Linus Torvalds 2005-04-16 244 __rem; \
^1da177e4c3f41 Linus Torvalds 2005-04-16 245 })
^1da177e4c3f41 Linus Torvalds 2005-04-16 246
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip