Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

[Pavel Machek]

Hi!

> > > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
> > > index 2a698df9da57..c15e1e3c5958 100644
> > > --- a/drivers/leds/Makefile
> > > +++ b/drivers/leds/Makefile
> > > @@ -93,6 +93,7 @@ obj-$(CONFIG_LEDS_TURRIS_OMNIA)		+=
> > > leds-turris-omnia.o obj-$(CONFIG_LEDS_WM831X_STATUS)	+=
> > > leds-wm831x-status.o obj-$(CONFIG_LEDS_WM8350)		+=
> > > leds-wm8350.o obj-$(CONFIG_LEDS_WRAP)			+=
> > > leds-wrap.o +obj-$(CONFIG_LEDS_SIEMENS_SIMATIC_IPC)	+=
> > > simatic-ipc-leds.o  
> > 
> > Let's put this into drivers/leds/simple. You'll have to create it.
> 
> Can you please go into detail why? We plan to add more devices in the
> future, which might in fact make this a little less simple. But we can
> discuss that when the time is right and start with simple.

There's already way too many drivers in the directory, and your driver
is very different from drivers for camera flash (for example).

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: Digital signature