Re: drivers/mtd/parsers/qcomsmempart.c:109 parse_qcomsmem_part() warn: passing zero to 'PTR_ERR'

From: Manivannan Sadhasivam
Date: Wed Mar 03 2021 - 13:40:51 EST


On Wed, Mar 03, 2021 at 09:48:40AM +0100, Miquel Raynal wrote:
> Hello,
>

[...]

> > PTR_ERR(NULL) is success. But let's just fix the IS_ERR_OR_NULL() check
> > to IS_ERR() so we don't have to wonder if returning success is
> > intentional.
>
> Thanks for the report, I've just sent the fix.
>

Thanks for that!

> @Manni, I thought you would be added in Cc automatically as you're the
> author of the fixed commit, but I was wrong, sorry for the mistake.
>

np.

Thanks,
Mani

> Thanks,
> Miquèl