RE: [EXT] [PATCH 12/30] scsi: qla4xxx: ql4_os: Fix formatting issues - missing '-' and '_'

[Nilesh Javali]

> -----Original Message-----
> From: Lee Jones <lee.jones@xxxxxxxxxx>
> Sent: Wednesday, March 3, 2021 8:16 PM
> To: lee.jones@xxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Nilesh Javali <njavali@xxxxxxxxxxx>;
> Manish Rangankar <mrangankar@xxxxxxxxxxx>; GR-QLogic-Storage-
> Upstream <GR-QLogic-Storage-Upstream@xxxxxxxxxxx>; James E.J.
> Bottomley <jejb@xxxxxxxxxxxxx>; Martin K. Petersen
> <martin.petersen@xxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx
> Subject: [EXT] [PATCH 12/30] scsi: qla4xxx: ql4_os: Fix formatting issues -
> missing '-' and '_'
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/scsi/qla4xxx/ql4_os.c:631: warning: expecting prototype for
> qla4xxx_create chap_list(). Prototype was for qla4xxx_create_chap_list()
> instead
>  drivers/scsi/qla4xxx/ql4_os.c:9643: warning: expecting prototype for gets
> called if(). Prototype was for qla4xxx_pci_mmio_enabled() instead
> 
> Cc: Nilesh Javali <njavali@xxxxxxxxxxx>
> Cc: Manish Rangankar <mrangankar@xxxxxxxxxxx>
> Cc: GR-QLogic-Storage-Upstream@xxxxxxxxxxx
> Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>
> Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
> Cc: linux-scsi@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
>  drivers/scsi/qla4xxx/ql4_os.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
> index 7bd9a4a04ad5d..597a64d91fe92 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -618,7 +618,7 @@ static umode_t qla4_attr_is_visible(int param_type,
> int param)
>  }
> 
>  /**
> - * qla4xxx_create chap_list - Create CHAP list from FLASH
> + * qla4xxx_create_chap_list - Create CHAP list from FLASH
>   * @ha: pointer to adapter structure
>   *
>   * Read flash and make a list of CHAP entries, during login when a CHAP
> entry
> @@ -9633,7 +9633,7 @@ qla4xxx_pci_error_detected(struct pci_dev *pdev,
> pci_channel_state_t state)
>  }
> 
>  /**
> - * qla4xxx_pci_mmio_enabled() gets called if
> + * qla4xxx_pci_mmio_enabled() - gets called if
>   * qla4xxx_pci_error_detected() returns PCI_ERS_RESULT_CAN_RECOVER
>   * and read/write to the device still works.
>   * @pdev: PCI device pointer
> --
> 2.27.0

Lee,

Thanks for the patch.
Ack-by: Nilesh Javali <njavali@xxxxxxxxxxx>