Re: [PATCH v4] ARM: Implement SLS mitigation

From: Linus Walleij
Date: Wed Mar 03 2021 - 13:24:13 EST


On Wed, Mar 3, 2021 at 4:29 PM David Laight <David.Laight@xxxxxxxxxx> wrote:
> > On Tue, Feb 23, 2021 at 11:05 AM Will Deacon <will@xxxxxxxxxx> wrote:

> > I wrote some suggestions on follow-ups in my reply, and I can
> > help out doing some of the patches, I think.
> >
> > Since ARM32 RET is mov pc, <>
> > git grep 'mov.*pc,' | wc -l gives 93 sites in arch/arm.
> > I suppose these need to come out:
> >
> > mov pc, lr
> > dsb(nsh);
> > isb();
>
> Won't that go horribly wrong for conditional returns?

It will so I would not insert it after those. It has to be
on a case-by-base basis, I am not planning any
search and replace operations.

Yours,
Linus Walleij