Re: [PATCH v2 3/3] mm/slub: Use percpu partial free counter

From: Matthew Wilcox
Date: Wed Mar 03 2021 - 12:54:16 EST


On Tue, Mar 02, 2021 at 10:14:53AM +0100, Christoph Lameter wrote:
> On Mon, 10 Aug 2020, Xunlei Pang wrote:
> > - atomic_long_t partial_free_objs;
> > + atomic_long_t __percpu *partial_free_objs;
>
> A percpu counter is never atomic. Just use unsigned long and use this_cpu
> operations for this thing. That should cut down further on the overhead.

What about allocations from interrupt context? Should this be a local_t
instead?