Re: [PATCH v2 01/10] fsdax: Factor helpers to simplify dax fault code

From: Christoph Hellwig
Date: Wed Mar 03 2021 - 11:31:48 EST


On Fri, Feb 26, 2021 at 08:20:21AM +0800, Shiyang Ruan wrote:
> The dax page fault code is too long and a bit difficult to read. And it
> is hard to understand when we trying to add new features. Some of the
> PTE/PMD codes have similar logic. So, factor them as helper functions to
> simplify the code.
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>