Re: [PATCH][next] mtd: nand: Fix error handling in nand_prog_page_op

From: Colin Ian King
Date: Wed Mar 03 2021 - 10:19:58 EST


On 03/03/2021 09:46, Miquel Raynal wrote:
> Hi Colin,
>
> Colin King <colin.king@xxxxxxxxxxxxx> wrote on Wed, 3 Mar 2021
> 09:42:46 +0000:
>
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> The less than zero comparison with status is always false because status
>> is a u8. Fix this by using ret as the return check for the call to
>> chip->legacy.waitfunc() and checking on this and assigning status to ret
>> if it is OK.
>>
>> Addresses-Coverity: ("Unsigned compared against 0")
>> Fixes: 52f67def97f1 ("mtd: nand: fix error handling in nand_prog_page_op() #1")
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Thanks for the fix, but this has been handled just an hour ago :)

Ah, missed that. Glad to know it's fixed.

>
> Cheers,
> Miquèl
>