Re: [PATCH v1 0/3] driver core: Set fw_devlink=on take II

[Michael Walle]

Am 2021-03-02 23:47, schrieb Saravana Kannan:
> On Tue, Mar 2, 2021 at 2:42 PM Saravana Kannan <saravanak@xxxxxxxxxx> 
> wrote:
> > On Tue, Mar 2, 2021 at 2:24 PM Michael Walle <michael@xxxxxxxx> wrote:
> > >
> > > Am 2021-03-02 22:11, schrieb Saravana Kannan:
> > > > I think Patch 1 should fix [4] without [5]. Can you test the series
> > > > please?
> > >
> > > Mh, I'm on latest linux-next (next-20210302) and I've applied patch 3/3
> > > and
> > > reverted commit 7007b745a508 ("PCI: layerscape: Convert to
> > > builtin_platform_driver()"). I'd assumed that PCIe shouldn't be working,
> > > right? But it is. Did I miss something?
> >
> > You need to revert [5].
>
> My bad. You did revert it. Ah... I wonder if it was due to
> fw_devlink.strict that I added. To break PCI again, also set
> fw_devlink.strict=1 in the kernel command line.

Indeed, adding fw_devlink.strict=1 will break PCI again. But if
I then apply 1/3 and 2/3 again, PCI is still broken. Just to be clear:
I'm keeping the fw_devlink.strict=1 parameter.

-michael