Re: [PATCH 01/12] Documentation: add BCM6328 pincontroller binding documentation

[Álvaro Fernández Rojas]

Hi Linus,

I think it's better if we leave the interrupts out for now.
It's not critical and it can be added later.

Best regards,
Álvaro.

El 02/03/2021 a las 16:23, Linus Walleij escribió:
> On Tue, Mar 2, 2021 at 3:57 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> > On Thu, Feb 25, 2021 at 5:42 PM Álvaro Fernández Rojas
> > <noltari@xxxxxxxxx> wrote:
> >
> > > Add binding documentation for the pincontrol core found in BCM6328 SoCs.
> > >
> > > Signed-off-by: Álvaro Fernández Rojas <noltari@xxxxxxxxx>
> > > Signed-off-by: Jonas Gorski <jonas.gorski@xxxxxxxxx>
> > (...)
> > > +  interrupts-extended:
> > > +    description:
> > > +      One interrupt per each of the 4 GPIO ports supported by the controller,
> > > +      sorted by port number ascending order.
> > > +    minItems: 4
> > > +    maxItems: 4
> >
> > I don't know if this is advisable, there are different ways
> > of specifying interrupts so this may become ambiguous,
> > I think Rob will know how/if to do this though.
>
> After reading the code I conclude this gpiochip is hierarchical so this should
> just be dropped, and we only need interrupt-parent assigned. The
> driver will know the hardware offsets between the interrupt parent
> and the GPIO block, this is generally the case for
> hierarchical interrupt controllers.
>
> Yours,
> Linus Walleij